From: Mario Sanchez Prada Date: Thu, 4 May 2017 17:09:39 +0000 (+0100) Subject: popupMenu: Change the position of the icon in PopupImageMenuItem X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~351 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=73680e2433f4b42bd9d38d27d74f3e4a91a13537;p=gnome-shell.git popupMenu: Change the position of the icon in PopupImageMenuItem We are moving the icon to be added before the text instead of after, which is consistent with other menu items in other popup menus, such as the ones in the system indicator's popup menu. https://bugzilla.gnome.org/show_bug.cgi?id=782166 --- diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js index 17a5a911a..fbe409ee2 100644 --- a/js/ui/popupMenu.js +++ b/js/ui/popupMenu.js @@ -394,10 +394,10 @@ const PopupImageMenuItem = new Lang.Class({ _init: function (text, icon, params) { this.parent(params); - this.label = new St.Label({ text: text }); - this.actor.add_child(this.label); this._icon = new St.Icon({ style_class: 'popup-menu-icon' }); this.actor.add_child(this._icon, { align: St.Align.END }); + this.label = new St.Label({ text: text }); + this.actor.add_child(this.label); this.actor.label_actor = this.label; this.setIcon(icon);